Fix Pkcs11::new bug preventing PKCS#11 library loading and bump rust-version and update deps #289

mematthias · 2025-06-19T18:57:50Z

Update crates: `cargo update` and fix Clippy warnings

This pull request was originally intended to cover multiple changes, but it has now been split into several smaller parts for clarity and easier review.

This PR is focused solely on crate updates and cleanup:

Re-ran cargo update to ensure dependencies are up to date
Fixed all warnings reported by cargo clippy

Further related changes will follow in separate pull requests.

Old description

// # Summary
//
// This PR fixes a critical issue in `Pkcs11::new` that prevented my PKCS#11 library from being loaded correctly. The root cause was the use of `MaybeUninit::uninit()` in a context where zero-initialized or `null`-assigned variables were required. This has been resolved by using explicitly `null`-assigned variables instead.
//
// # Changes
//
// - Fixed bug in `Pkcs11::new` related to improper initialization, resolving library loading failure
// - Made the `basic.rs` test module compile again
// - Ran `cargo update` to bring dependencies up to date
// - Raised `rust-version` to `1.77` in `Cargo.toml`, as `mem::offset_of` is used and only available from that version onward

Jakuje · 2025-06-23T10:06:36Z

Thank you for the fix for this issue!

It would be good if you could provide the changes at least in separate commits (or ideally as separate PRs) . Now there is everything mixed up in one commit (that is missing the sing-off) and then there is a fixup commit reverting one of the changes. We are certainly interested in the fix, but I am not sure if we want to pull all the changes of dependencies.

Do you know why the CI still works on the rust 1.66 when the offset_of is used? Or is it only on some configurations?

mematthias · 2025-06-23T17:49:10Z

I've opened a new #291 PR that includes only the small change related to Pkcs11::new.
Unfortunately, I don't immediately know why offset_of works within the CI.
I've only tested this on Windows without performing any manual configuration.

Jakuje · 2025-06-23T20:01:58Z

Interesting, The CI runs only on Linux now. From what I see, it looks the the offset_of was there before 1.77, but was stabilized with 1.77. Is there some way to run (at least build of rust crate) in GH Actions CI on Windows? It might help to catch some differences.

wiktor-k · 2025-06-24T08:34:46Z

Is there some way to run (at least build of rust crate) in GH Actions CI on Windows? It might help to catch some differences.

I've worked on it at #276. Maybe it'd be good to merge it early to have at least a check if everything looks sane? 🤔

hug-dev

Thank you!! Looks good to me but we need to:

decide if it's ok to bump the MRSV version. This mostly depends on where cryptoki is used: Ubuntu, Fedora, Microsoft, MacOS. We should have a look at what's the rustc version in the most common distribution
investigate why the MRSV CI check does not work 😅

You might also need to rebase to latest main since I have now added the Windows build as required!

cryptoki-sys/Cargo.toml

hug-dev

Thank you that's great!

hug-dev · 2025-07-11T08:02:24Z

cryptoki/Cargo.toml

Not related with your PR and you don't need to change anything here but this made me thinking that we could add a dependabot check in some nightly CI which could check that we use the latest dependencies, and update if not!

Agreed. It took me quite a while to locate the actual change, even though I've seen it earlier 😅

Maybe it's best to split this into several smaller PRs and keep this one only about the fix? 🤔

(Sorry for putting you for even more work 🙇 )

@mematthias made a good job of splitting between different commit and there seems to be one just to address the bug, would that be enough 🕵️?

That first commit is still kind-of packed: 860d945 and it includes stuff such as raising MRSV to 1.77 that has been done in another PR...

I just itches me to restructure these commits differently but... maybe it's just my OCD 😅

I think it should be just rebased (instead of doing the merge commits on the way.

Jakuje

The PR needs to be rebased (instead of including merge commits). Also the PR title needs adjustments to reflect the rust-version was really bumped in separate previous commit, otherwise it is super-confusing for any further reader.

Jakuje · 2025-07-11T17:21:19Z

cryptoki/Cargo.toml

-paste = "1.0.6"
+paste = "1.0.15"


for paste we have separate issue #279 where it is considered unmaintained (or feature complete -- depending on the point of view) and @hug-dev had a proposal to remove the dependency . Given that it is used only in one place and audit will show the issues with that, I would rather go with removing it than updating. @hug-dev can you open a PR with the proposed change in there to remove it?

Jakuje · 2025-07-11T17:26:13Z

cryptoki/Cargo.toml

I think it should be just rebased (instead of doing the merge commits on the way.

…ith `null`-assigned variables; this resolves an issue that prevented my PKCS#11 library from loading - Ran `cargo update` to refresh crate versions - Raised `rust-version` to 1.77 in `Cargo.toml`, since `mem::offset_of` is stabilized only in this version - Made `basic.rs` tests compile successfully again Signed-off-by: mematthias <107192630+mematthias@users.noreply.github.com>

Signed-off-by: mematthias <107192630+mematthias@users.noreply.github.com>

…version, and resolved all `cargo clippy` warnings Signed-off-by: mematthias <107192630+mematthias@users.noreply.github.com>

Signed-off-by: mematthias <107192630+mematthias@users.noreply.github.com>

mematthias mentioned this pull request Jun 23, 2025

Fix Pkcs11::new bug preventing PKCS#11 library loading #291

Merged

mematthias mentioned this pull request Jun 25, 2025

Fix Windows build compatibility #293

Merged

hug-dev reviewed Jun 26, 2025

View reviewed changes

cryptoki-sys/Cargo.toml Outdated Show resolved Hide resolved

cryptoki-sys/Cargo.toml Outdated Show resolved Hide resolved

mematthias force-pushed the main branch from cc35b53 to caa3f4d Compare June 26, 2025 18:35

mematthias force-pushed the main branch 2 times, most recently from 411a2fb to 5cdaf95 Compare July 10, 2025 20:04

hug-dev approved these changes Jul 11, 2025

View reviewed changes

Jakuje reviewed Jul 11, 2025

View reviewed changes

mematthias added 4 commits July 12, 2025 13:42

Revert fix: Re-added .into() for Linux compatibility

2aa4505

Signed-off-by: mematthias <107192630+mematthias@users.noreply.github.com>

Performed another cargo update, updated bitflags crate to latest …

fa1e79b

…version, and resolved all `cargo clippy` warnings Signed-off-by: mematthias <107192630+mematthias@users.noreply.github.com>

added missing hex crate again

7db90c9

Signed-off-by: mematthias <107192630+mematthias@users.noreply.github.com>

mematthias force-pushed the main branch from 5cdaf95 to 7db90c9 Compare July 12, 2025 11:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Pkcs11::new bug preventing PKCS#11 library loading and bump rust-version and update deps #289

Fix Pkcs11::new bug preventing PKCS#11 library loading and bump rust-version and update deps #289

mematthias commented Jun 19, 2025 •

edited

Loading

Uh oh!

Jakuje commented Jun 23, 2025

Uh oh!

mematthias commented Jun 23, 2025 •

edited

Loading

Uh oh!

Jakuje commented Jun 23, 2025

Uh oh!

wiktor-k commented Jun 24, 2025

Uh oh!

hug-dev left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

hug-dev left a comment

Uh oh!

hug-dev Jul 11, 2025

Uh oh!

wiktor-k Jul 11, 2025

Uh oh!

hug-dev Jul 11, 2025

Uh oh!

wiktor-k Jul 11, 2025

Uh oh!

Jakuje Jul 11, 2025

Uh oh!

Jakuje left a comment

Uh oh!

Jakuje Jul 11, 2025

Uh oh!

Jakuje Jul 11, 2025

Uh oh!

Uh oh!

Fix Pkcs11::new bug preventing PKCS#11 library loading and bump rust-version and update deps #289

Are you sure you want to change the base?

Fix Pkcs11::new bug preventing PKCS#11 library loading and bump rust-version and update deps #289

Conversation

mematthias commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Update crates: cargo update and fix Clippy warnings

Uh oh!

Jakuje commented Jun 23, 2025

Uh oh!

mematthias commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jakuje commented Jun 23, 2025

Uh oh!

wiktor-k commented Jun 24, 2025

Uh oh!

hug-dev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hug-dev left a comment

Choose a reason for hiding this comment

Uh oh!

hug-dev Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

wiktor-k Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

hug-dev Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

wiktor-k Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Jakuje Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Jakuje left a comment

Choose a reason for hiding this comment

Uh oh!

Jakuje Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Jakuje Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mematthias commented Jun 19, 2025 •

edited

Loading

Update crates: `cargo update` and fix Clippy warnings

mematthias commented Jun 23, 2025 •

edited

Loading

hug-dev left a comment •

edited

Loading